Skip to content

nyif course access workflows - #175

Merged
tkeemon merged 3 commits into
appsembler/ficus/developfrom
appsembler/ficus/feature/nyif-course-access-workflows
Oct 26, 2017
Merged

nyif course access workflows#175
tkeemon merged 3 commits into
appsembler/ficus/developfrom
appsembler/ficus/feature/nyif-course-access-workflows

Conversation

@tkeemon

@tkeemon tkeemon commented Oct 21, 2017

Copy link
Copy Markdown

There are two updates here:

First, I'm changing the method used to determine the Organization during a user registration. AMC relies on modifying the Site object to include a foreign key relationship with an Organization. Instead of taking that change, we're going to grab the course_org_filter from the SiteConfiguration.

Second, the course about page has been updated to include the course access request workflow. This ties in with the microsite theme changes here:
appsembler/edx-theme-customers@37667b1

If a manager indicates that a course requires special permission to access, a student can visit the course's about page, click on the "Enroll in COURSE_NAME" button, then a request will be sent to the manager.

@tkeemon

tkeemon commented Oct 21, 2017

Copy link
Copy Markdown
Author

@tkeemon tkeemon changed the title (WIP) nyif course access workflows nyif course access workflows Oct 21, 2017
@tkeemon
tkeemon force-pushed the appsembler/ficus/feature/nyif-course-access-workflows branch from 773a83b to fee1341 Compare October 21, 2017 16:13

@melvinsoft melvinsoft left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not very familiar with HR management and NYIF, but the PR looks good. I'm just worried about introducing custom code in edX views. I know some times there isn't another option, but I was wondering if there any workaround here.

@tkeemon

tkeemon commented Oct 25, 2017

Copy link
Copy Markdown
Author

@melvinsoft I know what you mean. We're trying to add some additional functionality into the view, so I don't think we have any other options. But I'm open to suggestions.

I made sure to check for the necessary packages and gracefully handle exceptions if they don't exist. From the perspective of a customer without these customizations, nothing will have changed.

@melvinsoft

Copy link
Copy Markdown

@tkeemon Yes, I agree, sometimes there is no other option than change platform code. I'm going to approve the PR, please make sure that we document the change in the project docs maybe, so we don't missing it while merging to Ginkgo.

@melvinsoft melvinsoft left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tkeemon

tkeemon commented Oct 26, 2017

Copy link
Copy Markdown
Author

Will do. Thanks @melvinsoft

@tkeemon
tkeemon merged commit 65df2f4 into appsembler/ficus/develop Oct 26, 2017
OmarIthawi pushed a commit that referenced this pull request Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants