specify media root in CMS and allow http scheme in aws_appsembler by env token - #171
Conversation
|
The last commit 500e7f4 is to fix a subsequent merge conflict resolution that chose the wrong commits. It's not related to the other commits, sorry, but trying to get this resolved quickly. udpate: this last commit was refactored to another PR. |
There was a problem hiding this comment.
@bryanlandia Could you please let me know the why you're refactoring (' -> " and the spacing)?
It's a bit difficult to separate the signal from the noise in this file.
|
Why are do we have a build if it fails all the time? I'd just remove it. |
OmarIthawi
left a comment
There was a problem hiding this comment.
It's not clear what have changed in advanced.js. Please consider refactoring in a separate PR. Or at least a separate final commit.
500e7f4 to
6294d66
Compare
|
@OmarIthawi Thanks. As you suggested, I removed the last commit to refactor as another PR. |
|
@OmarIthawi - The other PR is #169 |
|
Thanks @bryanlandia! Looks much better. One note (it might be unnecessary though). For the following conditions we might have a problem with this PR:
In this case the If the latter is not a problem please feel free to merge. Otherwise I think it is worth fixing. |
|
Thanks Omar. Right now, because of cross domain security issues in the
browser, SCORM assets can't be stored in S3. We would need to use
cloudfront in that case. I haven't worked that out yet.
|
Not sure that I understand why, please let me know if you'd like me to jump in. I should able to help in such issues. It looks good to go! Please feel free to merge it. |
SCORM XBlock using filestorage requires specifying
MEDIA_ROOTin cms as well as lms.Also, allow specifying HTTPS setting to off via
BASE_SCHEMEenv token from server-vars, for situations where we are usingaws_appsemblerenv on a staging server w/o SSL certs set up. Normally only devstack envs has HTTPS settings off