use AUTHENTICATION_BACKENDS from APPSEMBLER_FEATURES - #170
Merged
tkeemon merged 1 commit intoOct 8, 2017
Merged
Conversation
Author
melvinsoft
approved these changes
Sep 28, 2017
|
👍 LTBM @tkeemon but please take a look at my comment in https://github.com/noderabbit-team/edx-configs/pull/165 |
tkeemon
force-pushed
the
appsembler/ficus/feature/auth-backends-from-json
branch
from
October 8, 2017 13:41
a9faac7 to
b2972f2
Compare
tkeemon
force-pushed
the
appsembler/ficus/feature/auth-backends-from-json
branch
from
October 8, 2017 14:53
b2972f2 to
fa82658
Compare
Author
|
Thanks @melvinsoft. Merging now. |
OmarIthawi
pushed a commit
that referenced
this pull request
Aug 18, 2020
PROD-1236: Do not expose user id with certificate URL.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If
LMS_AUTHENTICATION_BACKENDSis set inAPPSEMBLER_FEATURES, then nuke the existingAUTHENTICATION_BACKENDSand use the settings in lms.env.json.This is done so NYIF can use a custom auth backend that prevents users from logging into microsites where their account wasn't originally registered.
Related edx-configs PR:
https://github.com/noderabbit-team/edx-configs/pull/165