Skip to content

Update advanced settings JS to multichoice settings fields #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bryanlandia merged 1 commit into from
Oct 6, 2017
Merged

Update advanced settings JS to multichoice settings fields #169

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 21 additions & 4 deletions cms/static/js/views/settings/advanced.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,19 +14,21 @@ define(['js/views/validation',
// Model class is CMS.Models.Settings.Advanced
events: {
'focus :input': 'focusInput',
'blur :input': 'blurInput'
'blur :input': 'blurInput',
'change select': 'clearValidationErrors',
'change select': 'selectSetField'
// TODO enable/disable save based on validation (currently enabled whenever there are changes)
},
initialize: function() {
this.template = HtmlUtils.template(
this.base_template = HtmlUtils.template(
$('#advanced_entry-tpl').text()
);
this.listenTo(this.model, 'invalid', this.handleValidationError);
this.render();
},
render: function() {
// catch potential outside call before template loaded
if (!this.template) return this;
if (!this.base_template) return this;

var listEle$ = this.$el.find('.course-advanced-policy-list');
listEle$.empty();
Expand Down Expand Up @@ -150,8 +152,9 @@ define(['js/views/validation',
});
},
renderTemplate: function(key, model) {
var tmpl = (model.values) ? this.options_template : this.base_template;
var newKeyId = _.uniqueId('policy_key_'),
newEle = this.template({key: key, display_name: model.display_name, help: model.help,
newEle = tmpl({key: key, display_name: model.display_name, help: model.help,
value: JSON.stringify(model.value, null, 4), deprecated: model.deprecated,
keyUniqueId: newKeyId, valueUniqueId: _.uniqueId('policy_value_')});

Expand All @@ -164,7 +167,21 @@ define(['js/views/validation',
},
blurInput: function(event) {
$(event.target).prev().removeClass('is-focused');
},
selectSetField : function(event) {
var self = this;
var key = this.selectorToField[event.currentTarget.id];
var newVal = $(event.currentTarget).val();
var JSONValue = JSON.parse(newVal);
var modelVal = self.model.get(key);
modelVal.value = JSONValue;
self.model.set(key, modelVal);
var message = gettext("Your changes will not take effect until you save your progress. Take care with key and value formatting, as validation is not implemented.");
self.showNotificationBar(message,
_.bind(self.saveView, self),
_.bind(self.revertView, self));
}

});

return AdvancedView;
Expand Down