Skip to content

Fixes for Badgr.io badges integration - #160

Merged
bryanlandia merged 4 commits into
appsembler/ficus/developfrom
appsembler/ficus/feature/badges-fix-badgr-integration
Sep 26, 2017
Merged

Fixes for Badgr.io badges integration#160
bryanlandia merged 4 commits into
appsembler/ficus/developfrom
appsembler/ficus/feature/badges-fix-badgr-integration

Conversation

@bryanlandia

Copy link
Copy Markdown

Badgr.io changed their backend so these badges app changes are now necessary for the integration to work. Also includes a custom change allowing course certificate URLs as evidence URLs on single-course 'course group' completion event badges.

when only a single course in course group
backend slugs no longer generated from component and submitted slug
because Badgr.io creates its own uuid-based slugs now
BadgeClasses unique by slug, and also by course mode w/ course id
Criteria passed to Badgr as criteria_text or criteria_url depending
look up Badge Classes by slug if passed or if not by mode + id
@bryanlandia
bryanlandia requested a review from amirtds September 6, 2017 23:28

@amirtds amirtds left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bryanlandia
bryanlandia merged commit aab9f3e into appsembler/ficus/develop Sep 26, 2017
@bryanlandia
bryanlandia deleted the appsembler/ficus/feature/badges-fix-badgr-integration branch November 23, 2017 01:50
OmarIthawi pushed a commit that referenced this pull request Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants