[Ficus] make custom redirect URL microsite aware - #147
Merged
melvinsoft merged 1 commit intoAug 4, 2017
Merged
Conversation
melvinsoft
changed the title
remove comment
melvinsoft
force-pushed
the
maxi/ficus-custom-redirect-url-microsite
branch
from
August 3, 2017 13:42
3379671 to
1513a77
Compare
bryanlandia
pushed a commit
that referenced
this pull request
Sep 24, 2018
…idation-on-account-page Fix for duplicate email validation on account settings page
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same as #146 but for Ficus.
This PR is a fix for our previous customization
CUSTOM_LOGOUT_REDIRECT_URL.The PR first, changes:
settings.CUSTOM_LOGOUT_REDIRECT_URLfor:
configuration_helpers.get_value('CUSTOM_LOGOUT_REDIRECT_URL', settings.CUSTOM_LOGOUT_REDIRECT_URL)So if we have an override on the microsite, will be used.
Also, sin the
targetis calculated on theLogoutViewis only calculated one time, and even having a microsite override, isn't calculated every time that the logout view is called, so we're moving it to a method, to force it to be calculated every time, and pick the microsite override if exists.