Skip to content

[SE-4101] fix: address VisibleBlocks caching race condition (#27359) - #1052

Merged
melvinsoft merged 1 commit into
mainfrom
maxi/persistent-grades-cherrypick
Dec 29, 2021
Merged

[SE-4101] fix: address VisibleBlocks caching race condition (#27359)#1052
melvinsoft merged 1 commit into
mainfrom
maxi/persistent-grades-cherrypick

Conversation

@melvinsoft

Copy link
Copy Markdown

This is a cherry pick from upstream. This commit resolves the issue MySQLdb._exceptions.IntegrityError: (1062, "Duplicate entry '3Hh/n7AUbv5mnoBtCTHE/4WYD5I=' for key 'hashed'") found after enabling persistent grades for some courses.

More info: https://discuss.openedx.org/t/have-an-duplicate-entry-error-after-enabling-persistent-grades/5668

…27359)

* fix: address VisibleBlocks caching race condition

* sets visual block creation in an atomic transaction

* refactor: add logging statement to bulk create

Co-authored-by: Raul Gallegos <raul@opencraft.com>
(cherry picked from commit 6ccdaca)

@OmarIthawi OmarIthawi left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @melvinsoft! Good find!

edX had no tests for this one, that's a first -- on less test to worry about 😄

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.003%) to 47.016% when pulling 77b1d58 on maxi/persistent-grades-cherrypick into ea4d1b9 on main.

@melvinsoft
melvinsoft merged commit 1825e0b into main Dec 29, 2021
@melvinsoft
melvinsoft deleted the maxi/persistent-grades-cherrypick branch December 29, 2021 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants