Remove default site creation commands - #65
Merged
Conversation
OmarIthawi
reviewed
Mar 26, 2021
OmarIthawi
left a comment
OmarIthawi
left a comment
There was a problem hiding this comment.
@AhmedAljazzar thanks! This fixes the issue, but at a cost. What are your thoughts?
Comment on lines
+36
to
+38
| make COMMAND='python manage.py lms create_devstack_site red devstack.tahoe' SERVICE='lms' tahoe.exec.single | ||
| docker exec -it tahoe.$(COMPOSE_PROJECT_NAME).amc python manage.py create_devstack_superuser | ||
| docker exec -it tahoe.$(COMPOSE_PROJECT_NAME).amc python manage.py create_devstack_site red | ||
| docker exec -it tahoe.$(COMPOSE_PROJECT_NAME).amc python manage.py create_devstack_site red devstack.tahoe |
There was a problem hiding this comment.
Thanks @AhmedAljazzar! This won't work for localhost environment.
We have a couple of options:
1- use an environment variable like ${TAHOE_BASE_DOMAIN:-localhost} so it's customizeable by Sultan
2- use devstack.tahoe (I don't like this option and prefer 4 instead)
3- use localhost
4- remove the create_devstack_site altogether
iamjazzar
force-pushed
the
jazzar/problem-builder
branch
from
March 29, 2021 16:45
937b48e to
86c5bd2
Compare
iamjazzar
changed the title
OmarIthawi
reviewed
Mar 29, 2021
OmarIthawi
left a comment
OmarIthawi
left a comment
There was a problem hiding this comment.
Thanks! One more change so the docs are up to date:
| 127.0.0.1 blue.localhost green.localhost # Create as many of those as you wish | ||
| 127.0.0.1 blue.devstack.tahoe green.devstack.tahoe # Create as many of those as you wish | ||
|
|
||
| Where's my Site? |
There was a problem hiding this comment.
Ahmed please modify that section to note that create_devstack_site is needed. Something like the following:
-Now you have a site of your own:
+To create a new site, please run the following commands: ... , ...
+
+Then you'll have a site of your own:
iamjazzar
force-pushed
the
jazzar/problem-builder
branch
from
March 30, 2021 01:09
86c5bd2 to
95b8d38
Compare
OmarIthawi
approved these changes
Mar 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
What sparked this PR?
When I tried to setup a new devstack and provision it, it failed on
create_devstack_sitebecause of the recent change oncreate_devstack_sitein amc#472 and edx-platform#848What problem does it solve?
Related PRs
Release notes
Other
- [ ] Tests?