Support auto membership by MembershipRule - #15
Merged
Conversation
OmarIthawi
force-pushed
the
omar/automatic
branch
from
February 15, 2020 23:05
c333c27 to
9b6de44
Compare
OmarIthawi
force-pushed
the
omar/oe-plugin
branch
2 times, most recently
from
February 15, 2020 23:51
61f961b to
1f64f7d
Compare
OmarIthawi
force-pushed
the
omar/automatic
branch
2 times, most recently
from
February 15, 2020 23:57
0bb226e to
cf61a68
Compare
OmarIthawi
force-pushed
the
omar/automatic
branch
2 times, most recently
from
February 16, 2020 10:39
6acd225 to
b4eabe8
Compare
3 tasks
johnbaldwin
reviewed
Feb 16, 2020
johnbaldwin
reviewed
Feb 16, 2020
johnbaldwin
reviewed
Feb 16, 2020
| group = models.ForeignKey(CourseAccessGroup, on_delete=models.CASCADE) | ||
|
|
||
| @classmethod | ||
| def apply_for_user(cls, user): |
There was a problem hiding this comment.
This class method looks like it fits a grey area between being a model method in Membership or in MembershipRule or a model manager method. One could justify that since this is retrieving or creating a Membership instance, it should be in Membership or MembershipManager instead of MembershipRule
Contributor
Author
There was a problem hiding this comment.
It was 50/50 for me, and I chose MembershipRule. Now moved to Membership. Thanks John for breaking the tie.
|
@OmarIthawi I started reviewing, about halfway through |
OmarIthawi
force-pushed
the
omar/automatic
branch
from
February 16, 2020 14:03
b4eabe8 to
ef3bcdd
Compare
OmarIthawi
force-pushed
the
omar/automatic
branch
2 times, most recently
from
February 16, 2020 14:24
1fdf76a to
d3312ed
Compare
OmarIthawi
force-pushed
the
omar/automatic
branch
from
February 18, 2020 08:00
a11565e to
6976292
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires the
USER_ACCOUNT_ACTIVATEDsignal (appsembler/edx-platform#527) to work with Open edX well.Jira: RED-707: Automatic domain-name-based enrollment for Course Access Groups
Notes: