Skip to content

Problem builder xblock juniper compatible version - #350

Closed
iamjazzar wants to merge 1 commit into
appsembler/hawthorn/masterfrom
jazzar/problem-builder
Closed

Problem builder xblock juniper compatible version#350
iamjazzar wants to merge 1 commit into
appsembler/hawthorn/masterfrom
jazzar/problem-builder

Conversation

@iamjazzar

@iamjazzar iamjazzar commented Mar 25, 2021

Copy link
Copy Markdown

Configuration Pull Request

NOTE

I'm not sure about this change, but I saw the requirement defined here. If it's not related feel free to close the PR.

Make sure that the following steps are done before merging:

  • A DevOps team member has approved the PR.
  • Are you adding any new default values that need to be overridden when this change goes live? If so:
    • Update the appropriate internal repo (be sure to update for all our environments)
    • If you are updating a secure value rather than an internal one, file a DEVOPS ticket with details.
    • Add an entry to the CHANGELOG.
  • If you are making a complicated change, have you performed the proper testing specified on the Ops Ansible Testing Checklist? Adding a new variable does not require the full list (although testing on a sandbox is a great idea to ensure it links with your downstream code changes).

@OmarIthawi OmarIthawi left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AhmedAljazzar I don't think this is being used EDXAPP_PRIVATE_REQUIREMENTS on Tahoe/SaaS customers.

I think we should close this PR unmerged.

$ git grep EDXAPP_PRIVATE_REQUIREMENTS
appsembler/sandbox/hawthorn/prod/files/server-vars.yml:EDXAPP_PRIVATE_REQUIREMENTS: []
appsembler/tahoe-uk/prod/files/server-vars.yml:EDXAPP_PRIVATE_REQUIREMENTS: []
appsembler/tahoe/prod/files/server-vars.yml:EDXAPP_PRIVATE_REQUIREMENTS: []
appsembler/tahoe/staging/files/server-vars.yml:EDXAPP_PRIVATE_REQUIREMENTS:
appsembler/tahoe/us/juniper/staging/files/server-vars.yml:EDXAPP_PRIVATE_REQUIREMENTS: []
aquent-hawthorn/prod/files/server-vars.yml:EDXAPP_PRIVATE_REQUIREMENTS: []
baseSettings/files/ginkgo-base.yml:EDXAPP_PRIVATE_REQUIREMENTS:

@iamjazzar

Copy link
Copy Markdown
Author

Closing in favor of edx-configs#1052

@iamjazzar iamjazzar closed this Mar 29, 2021
@OmarIthawi
OmarIthawi deleted the jazzar/problem-builder branch March 29, 2021 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants