run our backups script in a virtualenv - #343
Merged
Merged
Conversation
it requires a fair number of dependencies installed which sometimes conflict with other system packages and cause problems. This puts everything into a dedicated virtualenv to avoid messing up the shared system packages.
thraxil
marked this pull request as ready for review
January 27, 2021 15:22
amirtds
approved these changes
Feb 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
it requires a fair number of dependencies installed which sometimes conflict with other system packages and cause problems.
This puts everything into a dedicated virtualenv to avoid messing up the shared system packages.
A previous PR (#338) introduced a rough hack to downgrade
urllib3to avoid conflicts with Ansible. That was a temporary fix. This should be the longer term more correct approach. (so this PR remves that downgrade).