Skip to content

downgrade urllib3 #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thraxil merged 1 commit into from
Jan 8, 2021
Merged

downgrade urllib3 #338

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions playbooks/roles/backups/tasks/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,3 +147,18 @@
- service: mysql
enabled: "{{ BACKUPS_MYSQL }}"
tags: ['backups']

# one of the system-wide pip installs that runs at some point previous
# to install libraries upgrades urllib3 to a version that breaks
# ansible on subsequent deploys.
# See: https://appsembler.atlassian.net/wiki/spaces/ED/pages/390004931/Failed+to+install+repo+key
# the *correct* fix for this would be to have our backups script and
# its dependencies installed into a virtualenv so it doesn't conflict
# with system-wide libraries. That's a large change though
# so for now, as a workaround, we just downgrade urllib3 back to a known safe version
- name: pin urllib3 back down to a version that doesn't break ansible
pip: name={{ item.name }} version={{ item.version }}
with_items:
- {name: urllib3, version: 1.13.1}

@OmarIthawi OmarIthawi Jan 8, 2021

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nicer look.

Suggested change
- {name: urllib3, version: 1.13.1}
- name: urllib3
version: 1.13.1

when: BACKUPS_PROVIDER == 'gs'

@OmarIthawi OmarIthawi Jan 8, 2021

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case we forgot to remove this in Juniper.

Suggested change
when: BACKUPS_PROVIDER == 'gs'
when:
- BACKUPS_PROVIDER == 'gs'
- BACKUPS_URLLIB3_DOWNGRADE | default(False)

tags: ['backups']