Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: メッセージの変更差分の改善 #669

Merged
merged 3 commits into from
Jan 24, 2023
Merged

feat: メッセージの変更差分の改善 #669

merged 3 commits into from
Jan 24, 2023

Conversation

MikuroXina
Copy link
Collaborator

@MikuroXina MikuroXina commented Jan 14, 2023

close #665

Type of Change:

機能の変更, 依存関係の更新

Details of implementation (実施内容)

メッセージの変更差分を, 行ごとで変更があった箇所を強調表示する仕組みに変えました.

@m1sk9 m1sk9 closed this Jan 22, 2023
@m1sk9 m1sk9 deleted the feat/#665 branch January 22, 2023 17:29
@m1sk9 m1sk9 restored the feat/#665 branch January 22, 2023 17:31
@m1sk9 m1sk9 reopened this Jan 22, 2023
@m1sk9
Copy link
Contributor

m1sk9 commented Jan 22, 2023

手が滑りました

@MikuroXina MikuroXina marked this pull request as ready for review January 24, 2023 05:21
@MikuroXina MikuroXina requested a review from m1sk9 January 24, 2023 05:21
@MikuroXina MikuroXina self-assigned this Jan 24, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #669 (1ff204e) into main (8cf8bc1) will increase coverage by 0.02%.
The diff coverage is 74.07%.

@@            Coverage Diff             @@
##             main     #669      +/-   ##
==========================================
+ Coverage   72.53%   72.56%   +0.02%     
==========================================
  Files          67       67              
  Lines        4683     4691       +8     
  Branches      440      443       +3     
==========================================
+ Hits         3397     3404       +7     
+ Misses        849      847       -2     
- Partials      437      440       +3     
Flag Coverage Δ
unittests 72.56% <74.07%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/service/difference-detector.ts 81.94% <68.18%> (+0.69%) ⬆️
src/model/judging-status.ts 48.83% <100.00%> (ø)
src/service/command/meme/ojaru.ts 82.35% <100.00%> (ø)
src/service/command/meme/takopi.ts 83.33% <100.00%> (ø)
src/service/command/party.ts 81.89% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@m1sk9 m1sk9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
eslint が typeof 演算子に () をつける件についてはこっちでちゃんと調べてみます

@MikuroXina MikuroXina merged commit e3950be into main Jan 24, 2023
@MikuroXina MikuroXina deleted the feat/#665 branch January 24, 2023 10:07
This was referenced Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: DifferenceDetector の出力の改善
3 participants