-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: メッセージの変更差分の改善 #669
feat: メッセージの変更差分の改善 #669
Conversation
手が滑りました |
Codecov Report
@@ Coverage Diff @@
## main #669 +/- ##
==========================================
+ Coverage 72.53% 72.56% +0.02%
==========================================
Files 67 67
Lines 4683 4691 +8
Branches 440 443 +3
==========================================
+ Hits 3397 3404 +7
+ Misses 849 847 -2
- Partials 437 440 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
eslint が typeof 演算子に ()
をつける件についてはこっちでちゃんと調べてみます
close #665
Type of Change:
機能の変更, 依存関係の更新
Details of implementation (実施内容)
メッセージの変更差分を, 行ごとで変更があった箇所を強調表示する仕組みに変えました.