Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 空のメッセージに反応するバグを修正 #363

Merged
merged 1 commit into from
Jul 30, 2022

Conversation

MikuroXina
Copy link
Collaborator

Type of Change:

コードのバグ修正

Details of implementation (実施内容)

Discord.js のバージョン更新の際に, メッセージ本文が null の代わりに '' になることがある仕様変更を確認していました. しかし, それに起因するバグが発生したため検知して弾くようにコードを修正しました.

@MikuroXina MikuroXina enabled auto-merge (squash) July 30, 2022 16:50
@MikuroXina MikuroXina self-assigned this Jul 30, 2022
@MikuroXina MikuroXina requested a review from m1sk9 July 30, 2022 16:50
@MikuroXina MikuroXina added the bug label Jul 30, 2022
@MikuroXina MikuroXina disabled auto-merge July 30, 2022 16:53
@codecov-commenter
Copy link

codecov-commenter commented Jul 30, 2022

Codecov Report

Merging #363 (d6f143d) into main (77e1891) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #363      +/-   ##
==========================================
- Coverage   69.31%   69.25%   -0.06%     
==========================================
  Files          53       53              
  Lines        3484     3487       +3     
  Branches      331      331              
==========================================
  Hits         2415     2415              
- Misses        738      741       +3     
  Partials      331      331              
Flag Coverage Δ
unittests 69.25% <0.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/adaptor/proxy/transformer/message-convert.ts 41.84% <0.00%> (-0.70%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us.

@MikuroXina MikuroXina enabled auto-merge (squash) July 30, 2022 16:54
@MikuroXina MikuroXina merged commit 5ec6ef6 into main Jul 30, 2022
@MikuroXina MikuroXina deleted the fix/embed-reaction branch July 30, 2022 16:58
@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2022

🎉 This PR is included in version 1.22.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants