Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 逃げたねコピペ構文の追加 #322

Merged
merged 4 commits into from
Jul 12, 2022
Merged

feat: 逃げたねコピペ構文の追加 #322

merged 4 commits into from
Jul 12, 2022

Conversation

nanai10a
Copy link
Sponsor Member

Type of Change:

逃げたねコピペ構文の追加.

Details of implementation (実施内容)

他のmemeの実装に従い, 逃げたねコピペ構文を生成する機能を追加しました.

Additional Information (追加情報)

見た目が思ってたのと違うかも知れません. あとArcaea勢への若干のネタバレの心配があります. 時事ネタなので.

@nanai10a nanai10a self-assigned this Jul 12, 2022
@nanai10a nanai10a changed the title feat: add meme nigetane.ts feat: 逃げたねコピペ構文の追加 Jul 12, 2022
@nanai10a nanai10a marked this pull request as ready for review July 12, 2022 16:36
@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2022

Codecov Report

Merging #322 (0018401) into main (ae52dad) will increase coverage by 0.10%.
The diff coverage is 93.33%.

@@            Coverage Diff             @@
##             main     #322      +/-   ##
==========================================
+ Coverage   68.60%   68.71%   +0.10%     
==========================================
  Files          46       47       +1     
  Lines        3182     3196      +14     
  Branches      300      301       +1     
==========================================
+ Hits         2183     2196      +13     
  Misses        699      699              
- Partials      300      301       +1     
Flag Coverage Δ
unittests 68.71% <93.33%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/service/meme/nigetane.ts 92.30% <92.30%> (ø)
src/service/meme.ts 72.72% <100.00%> (+0.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae52dad...0018401. Read the comment docs.

@nanai10a nanai10a merged commit 200025c into approvers:main Jul 12, 2022
@nanai10a nanai10a deleted the feat/add-nigetane-meme branch July 12, 2022 16:47
@github-actions
Copy link
Contributor

🎉 This PR is included in version 1.19.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants