Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: リリース CI の実行条件を schedule に変更 #181

Merged
merged 2 commits into from
May 13, 2022

Conversation

MikuroXina
Copy link
Collaborator

Type of Change:

CI ワークフローの修正

Details of implementation (実施内容)

リリース CI の実行条件を cron で毎週土曜日の正午 (YML 上の表記は UTC であることに注意) に変更しました. これによりデフォルトブランチの最後のコミットを用いて, 毎週リリースが自動作成されます.

Additional Information (追加情報)

semantic-release は差分を検知して変更が無いときはリリースを作成しないため, 空のリリースが作られることはありません.

@MikuroXina MikuroXina requested a review from m1sk9 May 12, 2022 13:22
@MikuroXina MikuroXina self-assigned this May 12, 2022
m1sk9
m1sk9 previously approved these changes May 13, 2022
@m1sk9
Copy link
Contributor

m1sk9 commented May 13, 2022

@MikuroXina これ、メンテナがタグを切った時にもリリースが切れるようにしたりも可能?

@MikuroXina
Copy link
Collaborator Author

@mk-el これは tags: を消しているのでできないですね. tags: を残してそれをできるようにしますか?

@m1sk9
Copy link
Contributor

m1sk9 commented May 13, 2022

@mk-el これは tags: を消しているのでできないですね. tags: を残してそれをできるようにしますか?

@MikuroXina 可能であればそうしたい

@codecov-commenter
Copy link

codecov-commenter commented May 13, 2022

Codecov Report

Merging #181 (0719b36) into main (a1d4a1c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #181   +/-   ##
=======================================
  Coverage   51.40%   51.40%           
=======================================
  Files          35       35           
  Lines         749      749           
  Branches      122      122           
=======================================
  Hits          385      385           
  Misses        245      245           
  Partials      119      119           
Flag Coverage Δ
unittests 51.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1d4a1c...0719b36. Read the comment docs.

@MikuroXina MikuroXina requested a review from m1sk9 May 13, 2022 07:33
Copy link
Contributor

@m1sk9 m1sk9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとう
LGTM~~

Copy link
Contributor

@KisaragiEffective KisaragiEffective left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOTE

.github/workflows/release.yml Show resolved Hide resolved
@MikuroXina MikuroXina merged commit 644c25a into main May 13, 2022
@MikuroXina MikuroXina deleted the ci/replace-release branch May 13, 2022 10:55
@github-actions
Copy link
Contributor

🎉 This PR is included in version 1.12.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants