Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improve condition of updating commands #1345

Merged
merged 1 commit into from
May 31, 2024
Merged

Conversation

MikuroXina
Copy link
Collaborator

Closes #1343.

Type of Change:

機能の改善

Dealing with Problems (問題への対処)

登録済コマンドが更新されているかどうかの判定関数を, 少し丁寧に実装することで条件を厳しくした.

@github-actions github-actions bot added the T-@oreorebot2/bot Type: OreOreBot2 Bot (packages/bot) label May 31, 2024
Copy link

codecov bot commented May 31, 2024

Codecov Report

Attention: Patch coverage is 84.21053% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 59.04%. Comparing base (9848f85) to head (58ad94c).

Files Patch % Lines
packages/bot/src/service/command/register.ts 84.21% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1345      +/-   ##
==========================================
+ Coverage   58.96%   59.04%   +0.07%     
==========================================
  Files         112      112              
  Lines        7323     7337      +14     
  Branches      530      530              
==========================================
+ Hits         4318     4332      +14     
  Misses       2476     2476              
  Partials      529      529              
Flag Coverage Δ
unittests 59.04% <84.21%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MikuroXina MikuroXina merged commit fd882ad into main May 31, 2024
13 checks passed
@MikuroXina MikuroXina deleted the validate-command-repo branch May 31, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-@oreorebot2/bot Type: OreOreBot2 Bot (packages/bot)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

コマンドの登録処理が効率化されないことがある
1 participant