Refactor enums to be uppercase and include @JsonValue for correct serialization #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changing the enums to be uppercase breaks existing code. We should probably bump to the next major version (or atleast next minor). What do you think? |
TFyre
force-pushed
the
fsteyn/beta15
branch
2 times, most recently
from
2c09ab0
to
9e9ddd3
Compare
|
I think we should revamp the whole version schema to match the version schema of Vaadin. F.e: |
* Add @JsonValue to value property of enum for correct serialization * Move @Push to ApexChartsAppShellConfigurator
TFyre
force-pushed
the
fsteyn/beta15
branch
from
9e9ddd3
to
436f065
Compare
|
Updated version to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based ontop of #141
@JsonValueto value property of enum for correct serializationFixes 100% stacked column chart doesn't work #131
@Pushto ApexChartsAppShellConfigurator