Proof of concept: G-code preview #35
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….1.0, @types/node: 16.11.11 -> 17.0.23, @types/uuid: 8.3.3 -> 8.3.4, @types/vscode: 1.62.0 -> 1.66.0, @typescript-eslint/eslint-plugin: 5.5.0 -> 5.18.0, @typescript-eslint/parser: 5.5.0 -> 5.18.0, chai: 4.3.4 -> 4.3.6, eslint: 8.3.0 -> 8.13.0, eslint-config-prettier: 8.3.0 -> 8.5.0, eslint-plugin-import: 2.25.3 -> 2.26.0, fork-ts-checker-webpack-plugin: 6.5.0 -> 7.2.3, mocha: 9.1.3 -> 9.2.2, prettier: 2.5.0 -> 2.6.2, shx: 0.3.3 -> 0.3.4, ts-loader: 9.2.6 -> 9.2.8, ts-node: 10.4.0 -> 10.7.0, typescript: 4.5.2 -> 4.6.3, webpack: 5.64.4 -> 5.72.0, webpack-cli: 4.9.1 -> 4.9.2
…ypescript-eslint/parser: 5.18.0 -> 5.19.0, glob: 7.2.0 -> 8.0.1
…7.0.24, fork-ts-checker-webpack-plugin: 7.2.4 -> 7.2.6
…lint-plugin: 5.19.0 -> 5.20.0, @typescript-eslint/parser: 5.19.0 -> 5.20.0
…in: 7.2.6 -> 7.2.7
…lint-plugin: 5.20.0 -> 5.21.0, @typescript-eslint/parser: 5.20.0 -> 5.21.0
…ck-plugin: 7.2.7 -> 7.2.11, mocha: 9.2.2 -> 10.0.0, ts-loader: 9.2.9 -> 9.3.0, typescript: 4.6.3 -> 4.6.4
…ypescript-eslint/parser: 5.21.0 -> 5.22.0
…ypescript-eslint/parser: 5.22.0 -> 5.23.0
… webpack: 5.72.0 -> 5.72.1
…lint-plugin: 5.23.0 -> 5.24.0, @typescript-eslint/parser: 5.23.0 -> 5.24.0
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTION
Related to ISSUE #34
Hi,
This is the code for the preview I mentioned in issue #34. As you can see is have just thrown the code into your extension. It build at the G-Code Preview command works.
I know its a mess right now. It should be refactored completely to comply with you coding standards and project structure. My time at the moment does not leave much room for coding, so not to waste a lot time refactoring something that could turn out not to be compatible with your vision for the vscode-gcode-syntax extension I will let it be up to you if we should proceed.
The point of this pull request is only to illustrates in what direction I was working with this preview. There is a lot of work to be done before it could be released in the vscode-gcode-syntax extension or in the one I was working on.
Best regards
Allan
CHECKLIST