Skip to content

Conversation

@yongja79
Copy link
Collaborator

@yongja79 yongja79 commented Apr 4, 2023

What this PR does / why we need it?:

Does this PR introduce a user-facing change?

  • User guide
  • CHANGELOG.md

Which issue(s) this PR fixes:

Fixes #

Copy link
Member

@leochr leochr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yongja79 Just added one comment. Looks good otherwise.

Please rebase on top of Dave's branch (he delivered a few commits). Thanks


declare -A E2E_TESTS=(
[ocp-e2e-run]=$(cat <<-EOF
[ocp-e2e-run-${ARCHITECTURE}]=$(cat <<-EOF
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WLO also added this below:
--env ARCHITECTURE=${ARCHITECTURE}

@yongja79 yongja79 force-pushed the auto-multi-arch-test branch from f3a1dda to d3703b1 Compare April 4, 2023 14:49
Copy link
Member

@leochr leochr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the update @yongja79, looks good. I'll ask Dave to pull your commits into his branch.

This was referenced Apr 4, 2023
@leochr
Copy link
Member

leochr commented Apr 11, 2023

Included with #485

@leochr leochr closed this Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants