Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve error handling and configuration in HTTP dispatch #822

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

appleboy
Copy link
Owner

@appleboy appleboy commented Dec 12, 2024

  • Enhance DispatchFeedback function documentation with detailed parameters and return values
  • Add context timeout handling in DispatchFeedback function
  • Trim header values before setting them in the request
  • Add error handling for non-OK HTTP response status in DispatchFeedback
  • Support proxy configuration from the environment in global.go

ref: #813

- Enhance `DispatchFeedback` function documentation with detailed parameters and return values
- Add context timeout handling in `DispatchFeedback` function
- Trim header values before setting them in the request
- Add error handling for non-OK HTTP response status in `DispatchFeedback`
- Support proxy configuration from the environment in `global.go`

Signed-off-by: Bo-Yi Wu <[email protected]>
@appleboy appleboy merged commit a19eef4 into master Dec 12, 2024
10 checks passed
@appleboy appleboy deleted the proxy branch December 12, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant