fix(timezone): remove stray UTC() call
#309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only in `TokenGenerator` `mw.TimeFunc().UTC()` is called (all other places do not call `UTC`), making the result inconsistent with the result of other functions.
UndeadBaneGitHub
changed the title
UTC() callUTC() call
|
This should be fixing a related issue: #296 |
appleboy
approved these changes
Dec 11, 2022
appleboy
changed the title
UTC() callUTC() call
Codecov Report
@@ Coverage Diff @@
## master #309 +/- ##
=======================================
Coverage 87.36% 87.36%
=======================================
Files 1 1
Lines 459 459
=======================================
Hits 401 401
Misses 45 45
Partials 13 13
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only in
TokenGeneratormw.TimeFunc().UTC()is called (all other places do not callUTC), making the result inconsistent with the result of other functions.