Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent panic when exp claim is empty or a string #192

Closed
wants to merge 1 commit into from
Closed

Prevent panic when exp claim is empty or a string #192

wants to merge 1 commit into from

Conversation

sverrirsig
Copy link

The "exp" field of the payload is very prone to causing panics. The middleware panics if:

  1. The field is missing
  2. The field is a string

This PR addresses both issues.

@sverrirsig
Copy link
Author

@appleboy

@appleboy
Copy link
Owner

I will take this.

@appleboy appleboy mentioned this pull request Feb 16, 2019
Merged
appleboy added a commit that referenced this pull request Feb 16, 2019
@appleboy
fix: Prevent panic when exp claim is empty or a string (#193)
ca1084e 
fix #192
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sverrirsig @appleboy