Fix plugins not being embedded when path contains spaces #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xaverix
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building for macOS, Unity generates Xcode project folder based on the Product Name. If Product Name contains spaces then the path will contain them too. Currently the script does not handle paths with spaces and will return exit code 1 during its build phase.
There are already some other Pull Requests (#31 or #38) that address this issue but they only focus on changing
$APPLE_PLUGIN_LIBRARY_ROOT, the build then runs fine (exit code of the build phase is 0) but the libraries are not getting embedded because of the error when running ditto command.