Skip to content

FilePath: enable building on Windows #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
milseman merged 1 commit into from
Mar 20, 2021
Merged

FilePath: enable building on Windows #41

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Sources/System/FilePath/FilePathComponents.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,7 @@ extension FilePath.Root: _PathSlice {
}
}
extension FilePath: _PlatformStringable {
@usableFromInline
Copy link
Contributor

@milseman milseman Mar 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lorentey we will need to version this for Darwin binary distribution, but otherwise I think this is an ok workaround.

Copy link
Member

@lorentey lorentey Dec 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding @usableFromInline would introduce this as ABI, which we don't actually need/want to do on Darwin. (Its availability wouldn't match the rest of FilePath, making it inconvenient.)

I'll try to figure out an alternative solution. I'm not sure why the caller needs to be marked @_alwaysEmitIntoClient on Windows, for example.

func _withPlatformString<Result>(_ body: (UnsafePointer<CInterop.PlatformChar>) throws -> Result) rethrows -> Result {
try _storage.withPlatformString(body)
}
Expand Down