Correctly handle path params with a hyphen in the name#602
Merged
Conversation
Contributor
Author
|
Actually, not just hyphen, but a period is also commonly used in path param names. Let me add that too. |
simonjbeaumont
approved these changes
Jul 23, 2024
Collaborator
simonjbeaumont
left a comment
simonjbeaumont
left a comment
There was a problem hiding this comment.
Nice patch, thanks for including a test.
Contributor
Author
|
@simonjbeaumont Thanks for the review. I did try to look for an authoritative source for "allowed characters in path parameter names", but couldn't find anything conclusive. So for now, this is what we support. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #601, check out the issue for details.
Modifications
Adds hyphen to the regular expression that parses out params from the URL template.
Result
Correctly handle path params with hyphens in the name.
Test Plan
Added a unit test.