Skip to content

Add the frozen keyword only to enums with the public or package modifiers #595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
czechboy0 merged 8 commits into from
Jul 22, 2024
Merged

Add the frozen keyword only to enums with the public or package modifiers #595

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
31bbd81
Add frozen keyword for public and package enums
ojun9 Jul 21, 2024
8d91b3b
Extracted the method to determine whether to add frozen
ojun9 Jul 21, 2024
44a792c
Add comment
ojun9 Jul 21, 2024
fa6f422
Add unit test for requiresFrozenAnnotation
ojun9 Jul 21, 2024
d0d1e64
Update SnippetBasedReferenceTests for frozen keyword
ojun9 Jul 21, 2024
ad24f0e
change method name for frozen enum
ojun9 Jul 21, 2024
4932289
Remove unnecessary white spaces
ojun9 Jul 22, 2024
41a86c5
comment out warnings-as-errors
ojun9 Jul 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion Sources/_OpenAPIGeneratorCore/Renderer/TextBasedRenderer.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -645,7 +645,12 @@ struct TextBasedRenderer: RendererProtocol {

/// Renders the specified enum declaration.
func renderEnum(_ enumDesc: EnumDescription) {
if enumDesc.isFrozen {
func shouldAnnotateAsFrozen(_ enumDesc: EnumDescription) -> Bool {
Comment thread
czechboy0 marked this conversation as resolved.
Outdated
guard enumDesc.isFrozen else { return false }
guard let accessModifier = enumDesc.accessModifier else { return false }
return accessModifier == .public || accessModifier == .package
}
if shouldAnnotateAsFrozen(enumDesc) {
writer.writeLine("@frozen ")
writer.nextLineAppendsToLastLine()
}
Expand Down