Skip to content

Use 5.9.0 explicitly to avoid getting 5.9.1#408

Closed
czechboy0 wants to merge 1 commit into
apple:mainfrom
czechboy0:hd-59-use-590
Closed

Use 5.9.0 explicitly to avoid getting 5.9.1#408
czechboy0 wants to merge 1 commit into
apple:mainfrom
czechboy0:hd-59-use-590

Conversation

@czechboy0

Copy link
Copy Markdown
Contributor

Motivation

In Swift 5.9.1, there were some improvements to corelibs-foundation around Sendability, however we need to keep supporting 5.9.0 toolchains.

One thing I learned today is that if you specify "5.9" from the docker registry, you might get "5.9.1", which we explicitly don't want, as we could miss issues that only show up on "5.9.0".

One option would be to have two pipelines, one for 5.9.0 and 5.9.1, however I don't think it's necessary, as we already have a 5.10 pipeline, verifying that newer toolchains work.

This PR bumps down the 5.9 pipeline explicitly to use 5.9.0.

Modifications

Explicitly require 5.9.0, instead of using the latest 5.9 toolchain.

Result

More issues are caught in CI instead of only hitting users who use 5.9.0 later.

Test Plan

Ran locally, still passes.

@simonjbeaumont

Copy link
Copy Markdown
Collaborator

Closing this as superseded by #411.

@czechboy0 czechboy0 deleted the hd-59-use-590 branch November 30, 2023 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants