Skip to content

Remove no-longer-needed @preconcurrencys #396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MahdiBM wants to merge 13 commits into from
Closed

Remove no-longer-needed @preconcurrencys #396

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
f6f84a1
remove @preconcurrency from URL, Data and Date
MahdiBM Nov 27, 2023
76f8755
more
MahdiBM Nov 27, 2023
08acd34
some less preconcurrency s
MahdiBM Nov 27, 2023
c87129b
even modify proposal
MahdiBM Nov 27, 2023
473f4e2
URL is still not Sendable
MahdiBM Nov 27, 2023
614a535
fix tests?
MahdiBM Nov 29, 2023
348ff3d
Merge branch 'main' into mmbm-fix-imports
MahdiBM Nov 29, 2023
0be3e7b
Merge branch 'main' into mmbm-fix-imports
czechboy0 Nov 30, 2023
bfd9a61
Merge remote-tracking branch 'upstream/main' into mmbm-fix-imports
MahdiBM Dec 2, 2023
55ceaf4
another try
MahdiBM Dec 2, 2023
56502a4
fix some imports
MahdiBM Dec 2, 2023
b7cab5e
soundness
MahdiBM Dec 2, 2023
1aaae4a
Merge branch 'main' into mmbm-fix-imports
czechboy0 Dec 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions Sources/_OpenAPIGeneratorCore/Layers/RenderedSwiftRepresentation.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,10 @@
//===----------------------------------------------------------------------===//
#if os(Linux)
@preconcurrency import struct Foundation.URL
@preconcurrency import struct Foundation.Data
#else
import struct Foundation.URL
import struct Foundation.Data
#endif
import struct Foundation.Data

/// An in-memory file that contains the generated Swift code.
typealias RenderedSwiftRepresentation = InMemoryOutputFile
Expand Down
6 changes: 5 additions & 1 deletion Sources/_OpenAPIGeneratorCore/Translator/CommonTypes/Constants.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,11 @@ enum Constants {
ImportDescription(moduleName: "OpenAPIRuntime", spi: "Generated"),
ImportDescription(
moduleName: "Foundation",
moduleTypes: ["struct Foundation.URL", "struct Foundation.Data", "struct Foundation.Date"],
moduleTypes: ["struct Foundation.Data", "struct Foundation.Date"]
),
ImportDescription(
moduleName: "Foundation",
moduleTypes: ["struct Foundation.URL"],
preconcurrency: .onOS(["Linux"])
),
Comment thread
czechboy0 marked this conversation as resolved.
]
Expand Down
9 changes: 4 additions & 5 deletions Sources/swift-openapi-generator/Documentation.docc/Proposals/SOAR-0007.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ public enum Operations {

This proposal covers generating the following additional API surface to
simplify providing inputs.

```swift
extension APIProtocol {
// The parameters to each overload will match those of the corresponding
Expand All @@ -202,7 +202,7 @@ extension APIProtocol {
This proposal also covers generating the following additional API surface to
simplify handling outputs.

```swift
```swift
// Note: Generating an extension is not prescriptive; implementations may
// generate these properties within the primary type definition.
extension Operations.getGreeting.Output {
Expand Down Expand Up @@ -323,13 +323,12 @@ Generated using the following command:
@_spi(Generated) import OpenAPIRuntime
#if os(Linux)
@preconcurrency import struct Foundation.URL
@preconcurrency import struct Foundation.Data
@preconcurrency import struct Foundation.Date
#else
import struct Foundation.URL
#endif
import struct Foundation.Data
import struct Foundation.Date
#endif

/// A type that performs HTTP operations defined by the OpenAPI document.
public protocol APIProtocol: Sendable {
/// - Remark: HTTP `GET /greet`.
Expand Down
3 changes: 1 addition & 2 deletions Sources/swift-openapi-generator/runGenerator.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,10 @@
//===----------------------------------------------------------------------===//
#if os(Linux)
@preconcurrency import struct Foundation.URL
@preconcurrency import struct Foundation.Data
#else
import struct Foundation.URL
import struct Foundation.Data
#endif
import struct Foundation.Data
import class Foundation.FileManager
import ArgumentParser
import _OpenAPIGeneratorCore
Expand Down