Clean up preconcurrency warnings#352
Closed
czechboy0 wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
No we actually still need them in some places. Closing. |
czechboy0
added a commit
that referenced
this pull request
Oct 30, 2023
Disable warnings-as-errors for nightlies ### Motivation In Swift 5.11/nigtlies Swift upgraded preconcurrency diagnostics from a remark to a warning, and since we run CI with warnings-as-errors, that broke it. I tried removing the preconcurrency attribute on imports in #352, but we still need it. Since main builds of Swift are still in-development, we shouldn't be so sensitive to changes there, so disabling warnings-as-errors for nightlies only (keeping for 5.8, 5.9, and 5.10). ### Modifications Disable warnings as errors on CI for nightlies. ### Result CI should pass again. ### Test Plan CI. Reviewed by: PeterAdams-A Builds: ✔︎ pull request validation (5.10) - Build finished. ✔︎ pull request validation (5.8) - Build finished. ✔︎ pull request validation (5.9) - Build finished. ✔︎ pull request validation (compatibility test) - Build finished. ✔︎ pull request validation (docc test) - Build finished. ✔︎ pull request validation (integration test) - Build finished. ✔︎ pull request validation (nightly) - Build finished. ✔︎ pull request validation (soundness) - Build finished. #353
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
On 5.11/nightly Swift upgraded preconcurrency diagnostics from a remark to a warning, and since we run CI with warnings-as-errors, that broke it. It's possible we don't need to use preconcurrency imports anymore, so trying that in this PR.
Modifications
Remove preconcurrency imports and see if CI passes.
Result
No more preconcurrency imports for the places we got a warning for.
Test Plan
CI.