Do not run windows nightly CI by default #3325
Merged
+6
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Not everything that relies on these workflows builds on windows. Unit tests and release builds should be explicitly enabled for windows builds. Modifications: Change default of windows nightly to false. Fix flag checks that enable nightly builds. Result: Easier to use CI workflows.
|
I shimmed this branch into two PRs to check the expected behavior:
|
FranzBusch
reviewed
Jul 29, 2025
| MATRIX_LINUX_NIGHTLY_NEXT_ENABLED: ${{ inputs.linux_nightly_6_1_enabled && inputs.linux_nightly_next_enabled }} | ||
| MATRIX_LINUX_NIGHTLY_NEXT_ENABLED: ${{ inputs.linux_nightly_6_1_enabled || inputs.linux_nightly_next_enabled }} |
There was a problem hiding this comment.
Why is this checking for 6.1 in the first place? Same comment for the one below
There was a problem hiding this comment.
The nightly builds used to be numbered (here 6.1). The new flag does not have that number, but the old flags are still around and marked as deprecated.
glbrntt
approved these changes
Jul 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Not everything that relies on these workflows builds on windows. Unit tests and release builds should be explicitly enabled for windows builds.
Modifications:
Change default of windows nightly to false. Fix flag checks that enable nightly builds.
Result:
Easier to use CI workflows.