Pick visionOS version for Xcode 16.2 #3307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glbrntt
commented
Jul 17, 2025
| @@ -367,7 +367,7 @@ jobs: | |||
| run: /usr/bin/xcodebuild -quiet -scheme ${BUILD_SCHEME} -destination "generic/platform=visionos" build | |||
| - name: visionOS test # arm only | |||
| if: '!cancelled() && inputs.visionos_xcode_test_enabled' | |||
| run: /usr/bin/xcodebuild -quiet -scheme ${BUILD_SCHEME} -destination "name=Apple Vision Pro" test | |||
| run: TARGET_OS=""; if [ "$XCODE_VERSION" = "16.2" ]; then TARGET_OS=",OS=2.3"; fi && /usr/bin/xcodebuild -quiet -scheme ${BUILD_SCHEME} -destination "name=Apple Vision Pro$TARGET_OS" test | |||
There was a problem hiding this comment.
This only rights on the scheduled CI jobs so this was tested by altering the PR job temporarily: cb1fd1a
Here's the test run: https://github.com/apple/swift-nio/actions/runs/16341431397
Lukasa
approved these changes
Jul 17, 2025
zaneenders
pushed a commit
to zaneenders/swift-nio
that referenced
this pull request
Jul 23, 2025
Motivation: The nightly visionOS tests are failing because there are too many simulators matching the given destination selector. Modifications: - On Xcode 16.2 use visionOS 2.3 Result: Nightly CI passes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The nightly visionOS tests are failing because there
are too many simulators matching the given destination
selector.
Modifications:
Result:
Nightly CI passes