Extend NIOEventLoopTickInfo with end-time and loop sleep time #3268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: NIO’s event loop can emit metrics. Currently, this includes the start time (i.e. when the loop started working) and the number of tasks which were executed in that tick. It would be useful to collect the time the loop tick ended and the length of time the loop was asleep before starting the tick. Modifications: The event loop has a new property to track the time between runs. The tick info collects two new values: * The time since the last run. * The time the loop finished. Result: The new metrics are available for collection.
josephnoir
force-pushed
the
loop-tick-info
branch
from
465d13c to
96b0d8b
Compare
glbrntt
reviewed
Jun 16, 2025
Lukasa
approved these changes
Jun 16, 2025
Co-authored-by: George Barnett <[email protected]>
glbrntt
approved these changes
Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
NIO’s event loop can emit metrics. Currently, this includes the start time (i.e. when the loop started working) and the number of tasks which were executed in that tick.
It would be useful to collect the time the loop tick ended and the length of time the loop was asleep before starting the tick.
Modifications
The event loop has a new property to track the time between runs. The tick info collects two new values:
For the first run, the sleep time is the time since the event loop was created.
Result
The new metrics are available for collection.