Benchmarks workflow prints diff when changes found #3258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: The current method of parsing the ASCII table output is brittle and because the text output and the stored thresholds in JSON have different precisions doesn't always work. Modifications: * In the event that a deviation is found re-run the benchmarks in update mode and print the git diff to the logs. * The threshold update script scrapes this from the logs and applys it locally so that it can then be committed. Result: More reliable threshold updates.
glbrntt
approved these changes
May 29, 2025
Co-authored-by: George Barnett <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The current method of parsing the ASCII table output is brittle and
because the text output and the stored thresholds in JSON have different
precisions doesn't always work.
Modifications:
Result:
More reliable threshold updates.
An example of this working: https://github.com/apple/swift-nio/actions/runs/15302748893?pr=3257