A script for updating benchmark thresholds from CI output #3151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: We have GitHub Actions CI running Swift Package Benchmark benchmarks on each commit but when the values don't match updating them can be time-consuming. Particularly because you need to may need to exactly match the running environment in CI to get matching numbers. Modifications: Added a new dev script which pulls the output for the benchmark GitHub actions runs on a PR and updates your local threshold files Result: Easier benchmark threshold updates
Lukasa
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We have GitHub Actions CI running Swift Package Benchmark benchmarks on each commit but when the values don't match updating them can be time consuming. Particularly because you need to may need to exactly match the running environment in CI to get matching numbers.
Modifications:
Added a new dev script which pulls the output for the benchmark GitHub actions runs on a PR and updates your local threshold files
Result:
Easier benchmark threshold updates
Example interaction (actually on my branch of NIO SSL where I've messed with the thresholds so they need an update):