Test allocations of isolated ELF views #3054
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation:
We've added isolated views onto EventLoopFutures. These are great,
but as initially implemented they add a bunch of overhead to the nonisolated
versions. That's not optimal, but before we change the code we should make sure
we have a benchmark baseline.
Modifications:
- Extend the test_future_lots_of_callbacks alloc test to add all the callbacks
that the isolated views have.
- Duplicate that test to one that adds isolated wrappers so we can compare.
Result:
Two regression tests whose allocation counts should be equal, but aren't.
gjcairo
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We've added isolated views onto EventLoopFutures. These are great, but as initially implemented they add a bunch of overhead to the nonisolated versions. That's not optimal, but before we change the code we should make sure we have a benchmark baseline.
Modifications:
Result:
Two regression tests whose allocation counts should be equal, but aren't.