Add Sendability annotations on SocketOptionProvider #3034
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glbrntt
approved these changes
Dec 18, 2024
Lukasa
force-pushed
the
cb-sendability-socket-option-provider
branch
3 times, most recently
from
9dd1f38 to
ac36011
Compare
Lukasa
force-pushed
the
cb-sendability-socket-option-provider
branch
from
ac36011 to
0895924
Compare
glbrntt
approved these changes
Jan 10, 2025
|
Merging over API breakage failure, which is wrong. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
SocketOptionProvider is used to apply a number of socket options. As part of using it in NIOPosix, it became apparent that several necessary sendability annotations are missing. Let's add those.
Modifications:
Result:
Tighter Sendable constraints on SocketOptionProvider.