Import Android instead for NIOEmbedded #3033
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull apple#3030 invokes C APIs that aren't in the extremely limited Bionic module, so import the much larger Android overlay instead.
finagolfin
commented
Dec 18, 2024
| @@ -130,7 +130,7 @@ public final class EmbeddedEventLoop: EventLoop, CustomStringConvertible { | |||
|
|
|||
| public let description = "EmbeddedEventLoop" | |||
|
|
|||
| #if canImport(Darwin) || canImport(Glibc) || canImport(Musl) || canImport(Bionic) | |||
| #if canImport(Darwin) || canImport(Glibc) || canImport(Musl) || canImport(Android) | |||
There was a problem hiding this comment.
The two conditionals are interchangeable, just updating this to match the actual import above.
Lukasa
approved these changes
Dec 18, 2024
This was referenced Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull #3030 invokes C APIs that aren't in the extremely limited Bionic module, so import the much larger Android overlay instead.
This just broke my daily Android CI.