Fix now-racy scheduled callback tests #3031
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation:
In PR 3026 we I fixed some warnings, but as part of doing so I eliminated
some complexity in the scheduled callback tests. Apparently I did that a
bit hard, as I lost a few synchronization edges that made the tests lightly
flaky.
Modifications:
- Re-add synchronization edges between the EL and the test when we advance
time
- Re-add synchronization edges after cancellation calls.
Result:
More reliable tests
FranzBusch
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
In PR 3026 we I fixed some warnings, but as part of doing so I eliminated some complexity in the scheduled callback tests. Apparently I did that a bit hard, as I lost a few synchronization edges that made the tests lightly flaky.
Modifications:
Result:
More reliable tests