Fixed minor typos and updated force unwraps. #273
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: I wanted to make sure that I fixed the minor typos and that I addressed the feedback that was provided to me in regards to force unwrapping. I also wanted to make sure my error messages were accurate. Modifications: Fixed a few minor typos and updated the force unwrap error messages. Result: Fixed typos and guard statements with accurate error messages.
|
Can one of the admins verify this patch? |
|
@swift-nio-bot test this please |
normanmaurer
approved these changes
Apr 4, 2018
|
@Lukasa / @agnosticdev that looks good to me too, thanks! |
|
Thank you very much for the feedback on changes made and for providing insight on the conditions where localAddress is used. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
I wanted to make sure that I fixed the minor typos and that I addressed
the feedback that was provided to me in regards to force unwrapping.
I also wanted to make sure my error messages were accurate.
Modifications:
Fixed a few minor typos and updated the force unwrap error messages.
Result:
Fixed typos and guard statements with accurate error messages.