Fix huge compile time of setUUIDBytes #2482
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glbrntt
approved these changes
Jul 26, 2023
|
@swift-server-bot test this please |
1proprogrammerchant
added a commit
to 1proprogrammerchant/swift-nio
that referenced
this pull request
Jul 26, 2023
Fix huge compile time of setUUIDBytes (apple#2482)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix huge compile time of
ByteBuffer.setUUIDBytesMotivation:
ByteBuffer.setUUIDBytestakes a lot of compile time.It takes 8000ms and it is 110000x slower than the minimum one.
Modifications:
It is assumed that the compile time is increasing exponentially due to the increase in the number of undetermined type variables in the type inference process.
So use
|=operator instead of|to reduce undetermined type variables.Result:
450x faster build time!
env
macOS 13.4.1 (c)