WIP: Reduce the amount of bootstrap async methods #2474
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FranzBusch
commented
Jul 13, 2023
Comment on lines
281
to
285
| for try await childChannel in channel.inboundStream { | ||
| for try await negotiationResult in channel.inboundStream { | ||
| group.addTask { | ||
| switch childChannel { | ||
| switch try await negotiationResult.resolve() { |
There was a problem hiding this comment.
This part here is the important change. Instead of having a NIOAsyncChannel of negotiation results we now have a channel of futures of negotiation results. This means that users have to resolve the result and can then decide what to do with it. It doesn't look too bad from a users perspective and allows us to significantly reduce the amount of code in NIO. cc @Lukasa @glbrntt @rnro
FranzBusch
commented
Jul 13, 2023
FranzBusch
force-pushed
the
fb-reduce-bootstraps
branch
from
643d9b5 to
c6eb536
Compare
FranzBusch
force-pushed
the
fb-reduce-bootstraps
branch
2 times, most recently
from
8af30cb to
c4f41b9
Compare
# Motivation When adding new async methods for all the bootstrap we had to create 3 sets of method for every bootstrap. This resulted in lots of code and only provided little benefit for users. # Modification This PR removes all bind/connect methods except the most generic ones. This leaves it up to the user to wrap their channels in a `NIOAsyncChannel` or to await the protocol negotiation result. # Result Less code to maintain on our side.
FranzBusch
force-pushed
the
fb-reduce-bootstraps
branch
from
c4f41b9 to
5e47822
Compare
Lukasa
approved these changes
Jul 21, 2023
@Lukasa Could you merge this over the failing API breakage CI please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When adding new async methods for all the bootstrap we had to create 3 sets of method for every bootstrap. This resulted in lots of code and only provided little benefit for users.
Modification
This PR removes all bind/connect methods except the most generic ones. This leaves it up to the user to wrap their channels in a
NIOAsyncChannelor to await the protocol negotiation result.Result
Less code to maintain on our side.