Restructure Package.swift
#2462
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnadoba
reviewed
Jul 6, 2023
glbrntt
reviewed
Jul 6, 2023
FranzBusch
force-pushed
the
fb-package-manifest
branch
2 times, most recently
from
c9b38c3 to
fba83e2
Compare
0xTim
reviewed
Jul 6, 2023
This might be a controversial PR! 🍿 # Motivation It always bothered me how our `Package.swift` is structured. First, we had a huge list of `targets` at the top that distracted from the `products`. The `products` are the important part for our adopters since those are the actual modules they can use. Secondly, the formatting of the targets made it hard to follow and resulted in unnecessary merge conflicts. # Modification This PR moves the targets back to the bottom and splits all the various array elements into separate elements. # Result Easier to understand `Package.swift` and less merge conflicts.
FranzBusch
force-pushed
the
fb-package-manifest
branch
from
fba83e2 to
f17c31b
Compare
|
Merging over the known allocation regression. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might be a controversial PR! 🍿
Motivation
It always bothered me how our
Package.swiftis structured. First, we had a huge list oftargetsat the top that distracted from theproducts. Theproductsare the important part for our adopters since those are the actual modules they can use. Secondly, the formatting of the targets made it hard to follow and resulted in unnecessary merge conflicts.Modification
This PR moves the targets back to the bottom and splits all the various array elements into separate elements.
Result
Easier to understand
Package.swiftand less merge conflicts.