NIOThrowingAsyncSequenceProducer throws when cancelled #2415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianfett
force-pushed
the
ff-async-sequence-producer-throws-when-cancelled
branch
from
6745e64 to
f8a3175
Compare
Lukasa
reviewed
Apr 28, 2023
| @@ -603,6 +618,9 @@ extension NIOThrowingAsyncSequenceProducer { | |||
| failure: Failure? | |||
| ) | |||
|
|
|||
| /// The state once a call to next has been cancelled. To reach this state we must cancel the source. | |||
There was a problem hiding this comment.
This comment is a bit confused: presumably we're cancelling the iterator, not the source.
There was a problem hiding this comment.
/// The state once a call to next has been cancelled. Cancel the source when entering this state.
@Lukasa Is this better?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NIOThrowingAsyncSequenceProducer throws when cancelled
Motivation:
Currently
NIOThrowingAsyncSequenceProducercurrently does not throw a CancellationError, if the AsyncSequence is cancelled while the buffer is not empty.Modifications:
NIOThrowingAsyncSequenceProducerthrow when cancelledResult: