Guard against re-entrance of close0 #239
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: We need to guard against re-entrance of close0. This can happen at the moment for two reasons: 1) A user adds a callback that calls close() again when the promise failed because socket.close() throws. 2) close() is called because Selector.deregister(...) throws and the user calls close() in errorCaught(...). Modifications: - Ensure we only notify the promise once we updated the internal state of the Channel and also failed all pending writes. This way we "fast-return" in close0(...) when called again. - Just ignore errors happending because of selector.deregister(...) Result: No more re-entrance issues in close0
|
I think the only way how I could test it partly would be if I make BaseSocket.close() non final and override it. WDYT ? |
|
@weissi yep... Thats why I asked if anyone has a better idea for a test ;) |
|
@normanmaurer sorry, didn't spot that. I think making |
|
Non-final |
|
IMO this is superseded by #220, so we could probably close this. |
|
Yep let me close... Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We need to guard against re-entrance of close0. This can happen at the moment for two reasons:
Modifications:
Result:
No more re-entrance issues in close0