Fix memory binding. #2376
Fix memory binding. #2376
Conversation
|
Can one of the admins verify this patch? |
11 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
@swift-server-bot test this please |
|
This LGTM but needs to be rebased onto main. |
|
This still needs to be rebased onto main, and sadly I can't do it as you haven't made the branch editable by admins. |
|
I synced the branch with swift-nio/main and asked to give you rights to resync it. |
|
@swift-server-bot test this please |
Fix memory binding.
Motivation:
According to the documentation the 'capacity' argument represent the amount of memory counted as instances of T. Number of bytes allocated for the memory block does not always the same value as a number of instances.
Modifications:
bindMemory(:, capacity:) called with capacity equal to number of items in the vector instead of size of vector in bytes.
Result:
Proper memory binding.