Allow writing and reading empty datagrams #2341
Conversation
|
Can one of the admins verify this patch? |
10 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
@swift-server-bot test this please |
Motivation: Empty UDP datagrams could be used to have a meaning. Empty datagrams were being silently dropped on write. Receiving an empty diagram causes an assertion failure (possible DDoS). Modifications: Remove early exit when writing empty datagrams and non-empty assertion when reading them. Result: We can now write and read empty datagrams.
Head branch was pushed to by a user without write access
hashemi
force-pushed
the
allow-empty-datagrams
branch
from
6acb5ff to
ec05d2c
Compare
|
Thanks @Lukasa. For some reason, the first time I ran the automated linux tests manifest generator it output the wrong year in the copyright field. I just fixed that 2022 to 2023. |
|
@swift-nio-bot test this please |
|
Congratulations on being the first committer of 2023! Unfortunate that means you ran into some tooling limitations: I'll merge #2342 and then we can rebase this on top of it and get it landed. |
|
@swift-server-bot test this please |
Motivation:
Empty UDP datagrams could be used to have a meaning. Empty datagrams were being silently dropped on write. Receiving an empty diagram causes an assertion failure (possible DDoS).
Modifications:
Remove early exit when writing empty datagrams and non-empty assertion when reading them.
Result:
We can now write and read empty datagrams.