Remove implicit ByteBuffer copy in copyMemory #2330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: withVeryUnsafeBytes has a reference to `self` that it is using. This necessarily triggers a copy when we subsequently use `self` inside the block. The effect of that copy is an extra retain/release pair, and a call to beginAccess, that we simply don't need. Modifications: Replace the call to `_setBytesAssumingUniqueBufferAccess` with a manually inlined equivalent. Result: Avoids the extra copy of `self`, removes a retain/release and a beginAccess.
dnadoba
approved these changes
Dec 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
withVeryUnsafeBytes has a reference to
selfthat it is using. This necessarily triggers a copy when we subsequently useselfinside the block. The effect of that copy is an extra retain/release pair, and a call to beginAccess, that we simply don't need.Modifications:
Replace the call to
_setBytesAssumingUniqueBufferAccesswith a manually inlined equivalent.Result:
Avoids the extra copy of
self, removes a retain/release and a beginAccess.