Remove #available(OSX 10.12, *) check which is not needed anymore #233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: At some point we needed to check for #available(OSX 10.12, *) which is not true anymore as we use our own Thread impl. Modifications: Remove #available(OSX 10.12, *) check Result: Remove incorrect and not needed check.
|
@normanmaurer Did you validate this against an older target release? |
|
@Lukasa no I did not (I even don't have such an old version here) but we only had the check in place because we used the init block that was added in 10.12: swift-nio/Sources/NIO/EventLoop.swift Line 642 in 4a2425f I remember talking with @weissi about it when we added the code ;) |
|
Ok cool, I tested and this appears to work fine back to 10.10. |
Lukasa
approved these changes
Mar 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
At some point we needed to check for #available(OSX 10.12, *) which is not true anymore as we use our own Thread impl.
Modifications:
Remove #available(OSX 10.12, *) check
Result:
Remove incorrect and not needed check.