Move 5.7 beta APIs to NIOCore #2300
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: As 5.7 has shipped we no longer need to keep these APIs in _NIOBeta. We're going to do a two-stage removal: first we're going to move the APIs to NIOCore and keep them in _NIOBeta with deprecations on them. In a later release, we'll remove the APIs from _NIOBeta entirely. Modifications: - Move the TimeAmount + Duration APIs to NIOCore - Deprecate the APIs in _NIOBeta. Result: We're on a path to remove _NIOBeta
FranzBusch
approved these changes
Oct 25, 2022
|
What about moving the tests as well? |
|
Yup, I'm moving them to NIOCoreTests. |
FranzBusch
approved these changes
Oct 25, 2022
Lukasa
added a commit
to Lukasa/swift-nio
that referenced
this pull request
Nov 21, 2022
Motivation: Having deprecated the NIOBeta entrypoints in apple#2300, we can now safely remove it. Modifications: Remove all source files in _NIOBeta Remove the _NIOBeta product and target Result: We're ready for 5.8 work!
Merged
Lukasa
added a commit
that referenced
this pull request
Nov 21, 2022
Motivation: Having deprecated the NIOBeta entrypoints in #2300, we can now safely remove it. Modifications: Remove all source files in _NIOBeta Remove the _NIOBeta product and target Result: We're ready for 5.8 work!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
As 5.7 has shipped we no longer need to keep these APIs in _NIOBeta. We're going to do a two-stage removal: first we're going to move the APIs to NIOCore and keep them in _NIOBeta with deprecations on them. In a later release, we'll remove the APIs from _NIOBeta entirely.
Modifications:
Result:
We're on a path to remove _NIOBeta